adding in nodejs engine requirement (#999)

* adding in nodejs engine requirement * lint fixes
jaredwray · Jan 30, 2025 · 707a2f6 · 707a2f6
1 parent d81e192
commit 707a2f6
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/packages/cacheable/package.json b/packages/cacheable/package.json
@@ -12,6 +12,9 @@
 			"import": "./dist/index.js"
 		}
 	},
+	"engines": {
+		"node": ">=20"
+	},
 	"repository": {
 		"type": "git",
 		"url": "git+https://github.com/jaredwray/cacheable.git",

diff --git a/packages/cacheable/test/index.test.ts b/packages/cacheable/test/index.test.ts
@@ -100,7 +100,7 @@ describe('cacheable options and properties', async () => {
 describe('cacheable stats', async () => {
 	test('should return stats', async () => {
 		const cacheable = new Cacheable();
-		const stats = cacheable.stats;
+		const {stats} = cacheable;
 		expect(stats.enabled).toBe(false);
 	});
 	test('should be able to enable stats', async () => {

diff --git a/packages/cacheable/test/memory.test.ts b/packages/cacheable/test/memory.test.ts
@@ -46,7 +46,7 @@ describe('CacheableMemory Options and Properties', () => {
 		cache.set('key2', 'value');
 		cache.set('key3', 'value');
 		cache.set('key4', 'value');
-		const keys = Array.from(cache.keys);
+		const keys = [...cache.keys];
 		expect(keys).toContain('key');
 		expect(keys).toContain('key1');
 		expect(keys).toContain('key2');
@@ -60,7 +60,7 @@ describe('CacheableMemory Options and Properties', () => {
 		cache.set('key2', 'value2');
 		cache.set('key3', 'value3');
 		cache.set('key4', 'value4');
-		const values = Array.from(cache.items);
+		const values = [...cache.items];
 		expect(values[0].value).toBe('value3');
 		expect(values[1].value).toBe('value4');
 		expect(values[2].value).toBe('value1');

diff --git a/packages/cacheable/test/wrap.test.ts b/packages/cacheable/test/wrap.test.ts
@@ -222,7 +222,7 @@ describe('wrap functions handling thrown errors', () => {
 
 		expect(result).toBe(undefined);
 		expect(errorCallCount).toBe(1);
-		const values = Array.from(cache.items);
+		const values = [...cache.items];
 		expect(values.length).toBe(0);
 	});