(ci/optim): add caching for yarn install #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
agilgur5
commented
Mar 19, 2020
•
agilgur5
commented
- via bahmutov/npm-install
- it handles all the cache steps, yarn vs. npm, OS differences, etc
- via bahmutov/npm-install - it handles all the cache steps, yarn vs. npm, OS differences, etc
agilgur5
force-pushed
the
ci-add-install-cache
branch
from
ecf8e65
to
f804c9e
Compare
agilgur5
changed the title
|
So it's at least twice as fast on the Ubuntu runs, which is great! But it fails on Windows and macOS and is probably a bit slower as a result. Filed bahmutov/npm-install#24 |
|
Merging as some caching is still better than no caching. And any bugfixes will probably apply without needing to make any changes. If changes need to be made, can improve on this at a later date. |
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
- via bahmutov/npm-install - it handles all the cache steps, yarn vs. npm, OS differences, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.