(refactor): replace rimraf, mkdirp, util.promisify with fs-extra funcs #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
force-pushed
the
remove-rimraf-mkdirp-etc
branch
from
59486e9
to
53ab68e
Compare
|
Resolve conflicts and merge |
- they're a lot cleaner and this is one of the explicit goals of
fs-extra per its "Why?" section of its README
- it's also already used internally in most places, so this nixes
the remaining places
(deps): remove rimraf, mkdirp, and their @types/ packages
agilgur5
force-pushed
the
remove-rimraf-mkdirp-etc
branch
from
53ab68e
to
461c111
Compare
|
Done (just cherry-picked to master). Look at all those beautiful green passing CI marks finally 😄 |
|
sweeet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs-extra per its "Why?" section of its README
the remaining places
(deps): remove rimraf, mkdirp, and their @types/ packages
Built on top of #500 , please merge that first
#500 actually took care of most of these use-cases, so this just finishes nixing the rest.