Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Typescript "esnext" target override from rollup config. #111

Merged
merged 1 commit into from
May 24, 2019
Merged

Remove Typescript "esnext" target override from rollup config. #111

merged 1 commit into from
May 24, 2019

Conversation

hedgerh
Copy link
Contributor

@hedgerh hedgerh commented May 24, 2019

Fixes #101

The config for the typescript rollup plugin had an esnext override for the target, so files weren't getting compiled down. Set a default to es5 that can be overridden by the tsconfig at the project level.

@hedgerh hedgerh mentioned this pull request May 24, 2019
Closed
@jaredpalmer jaredpalmer merged commit e06d690 into jaredpalmer:master May 24, 2019
@jaredpalmer jaredpalmer mentioned this pull request May 29, 2019
Merged
@sisp sisp mentioned this pull request Aug 30, 2019
Closed
@agilgur5 agilgur5 mentioned this pull request Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output not being compiled-down
2 participants
@hedgerh @jaredpalmer