Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add string[] to setFieldValue type definiton #4014

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kitosha05
Copy link

Issue

   onChange={(v) => {
                              setFieldValue(field, v)
                       }}

Issue: The above code does not work as intended if field contains a period. It results in creating a new key/value pair in the values array instead of just updating the value, so the form input doesn't get updated.

To get around this, I used:

    onChange={(v) => {
                              setFieldValue([`${field}`], v)
                       }}

This allows the form to work but now there is a type error because field is set to type string.

Solution:
Change type definition of field in setFieldValue to string | string[]

Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 9468988

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:08pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant