Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preconnect link to target search cluster #3388

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

francoischalifour
Copy link
Contributor

Same as reactjs/react.dev#3980

The appId was retrieved from props but the <Search> component is never instantiated with props. So the preconnect link targeted an unknown search cluster:

<link rel="preconnect" href="https://undefined-dsn.algolia.net" crossorigin="true">

This fixes the preconnect link by getting the appId from the website config.

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2021

⚠️ No Changeset found

Latest commit: e56685a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 25, 2021

@francoischalifour is attempting to deploy a commit to the Formium Team on Vercel.

A member of the Team first needs to authorize it.

@jaredpalmer jaredpalmer merged commit b9cc253 into jaredpalmer:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants