Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/api/v1/firewall/nat/port_forward allows port range on localport field #253

Closed
jaredhendrickson13 opened this issue Jun 28, 2022 · 0 comments · Fixed by #248
Closed

/api/v1/firewall/nat/port_forward allows port range on localport field #253

jaredhendrickson13 opened this issue Jun 28, 2022 · 0 comments · Fixed by #248
Labels
bug Something isn't working

Comments

@jaredhendrickson13
Copy link
Owner

Describe the bug
POST and PUT requests to /api/v1/firewall/nat/port_forward allows clients to specify a port range in the localport field which throws an error in the webConfigurator.

To Reproduce
Make a POST or PUT request to /api/v1/firewall/nat/port_forward and specify a localport value of 1000:2000 and reload the firewall filter. Check the webConfigurator and you'll see an error was encountered when reloading the filter.

Expected behavior
The starting port of the range is all that is expected by pfSense and the end range will be automatically calculated. API calls should mimic this behavior.

pfSense Version & Package Version:

  • pfSense Version: v2.6.0 (affects all versions however)
  • Package Version: v1.4.2

Affected Endpoints:

  • URL: /api/v1/firewall/nat/port_forward
@jaredhendrickson13 jaredhendrickson13 added the bug Something isn't working label Jun 28, 2022
jaredhendrickson13 added a commit that referenced this issue Jun 28, 2022

Unverified

This user has not yet uploaded their public signing key.
…wall/nat/port_forward. #253
@jaredhendrickson13 jaredhendrickson13 linked a pull request Jun 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant