Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spread operator instead of for in #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use spread operator instead of for in #11

wants to merge 2 commits into from

Conversation

osimek1
Copy link

@osimek1 osimek1 commented Jun 1, 2021

Merge should not mutate input parameter
Fixes #10 (comment)
Should help with #8 (comment)

@jimmywarting
Copy link

jimmywarting commented Sep 5, 2022 •
edited
Loading

this changes the semantic of how this pkg works!
this lib looks and behave like Object.assign

honestly i don't think this pkg is needed anymore. just use spread or Object.assign directly instead of depending on this pkg

imo i think this pkg should be deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merging mutates input object
2 participants
@osimek1 @jimmywarting