Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Strategy if already a Strategy object #614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JSteunou
Copy link

@JSteunou JSteunou commented Oct 6, 2017

Fixes #613

@coveralls
Copy link

coveralls commented Oct 6, 2017

Coverage Status

Coverage decreased (-0.3%) to 98.599% when pulling 056c0e1 on JSteunou:patch-1 into 821a474 on jaredhanson:master.

@JSteunou
Copy link
Author

@jaredhanson I would appreciate a review on this.

Also CI is falling on one test but old node version (0.6, should not be supported anymore) and not related to this change I think.

@rwky
Copy link

rwky commented Jul 7, 2018

@JSteunou if you create this PR at https://github.com/passport-next/passport with tests it will get looked into.

@JSteunou
Copy link
Author

@rwky who is behind passport-next?

@rwky
Copy link

rwky commented Jul 11, 2018

@JSteunou I am and one of the companies I work for, we use several passport modules so I forked them into an organization so even if we stop using them for whatever reason or I get hit by a bus others can commit/publish etc.

@rwky
Copy link

rwky commented Jul 11, 2018

p.s. if you're interested in helping maintain passport-next I'm happy to add you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants