Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a way to add more userProfile parser to use other google API #36

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jbpin
Copy link

@jbpin jbpin commented Oct 21, 2017

Added a new options on the Strategy called profileParser that allow a developer to add a custom profile parser to handle more user fields or use another google API such as People API (https://developers.google.com/people/api/rest/)

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.6%) to 93.388% when pulling 6eaa0cd on jbpin:master into 2b0039a on jaredhanson:master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 21, 2017

Coverage Status

Coverage decreased (-6.6%) to 93.388% when pulling 6eaa0cd on jbpin:master into 2b0039a on jaredhanson:master.

@coveralls
Copy link

coveralls commented Oct 23, 2017

Coverage Status

Coverage decreased (-6.6%) to 93.388% when pulling 1a745fb on jbpin:master into 2b0039a on jaredhanson:master.

@alexeimoisseev
Copy link

This feature is really important. The current way of parsing userinfo is not flexible at all. E.g. I don't want this strategy to make user profile contain useless "value" fields in emails and in other places.

emails": [
{
"value": "user@gmail.com"
}
],

@jaredhanson please accept this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants