Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use functionality from jaraco.functools #109

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Re-use functionality from jaraco.functools #109

merged 1 commit into from
Sep 13, 2024

Conversation

jaraco
Copy link
Owner

@jaraco jaraco commented Aug 6, 2023

No description provided.

@jaraco jaraco closed this Dec 16, 2023
@jaraco jaraco reopened this Dec 16, 2023
@jaraco
Copy link
Owner Author

jaraco commented Dec 16, 2023

It's interesting. The tests on Windows become flaky with this change when the alpharep fixture is still in use (presumably from a previous test). The fact that it's flaky makes me think the method_cache or save_method_args is somehow not releasing the references as quickly as they would in the prior implementation. Merge with caution.

@jaraco jaraco marked this pull request as draft December 16, 2023 19:13
@jaraco jaraco force-pushed the feature/functools branch 2 times, most recently from 1a944fa to b93c977 Compare September 13, 2024 15:13
@jaraco jaraco marked this pull request as ready for review September 13, 2024 15:16
@jaraco
Copy link
Owner Author

jaraco commented Sep 13, 2024

In e23cbba, I chose to use functools.cached_property instead, and in this PR, I'm only looking to re-use save_method_args.

@jaraco jaraco merged commit 466f535 into main Sep 13, 2024
32 checks passed
@jaraco jaraco deleted the feature/functools branch September 13, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jaraco