Replace copy of license with an SPDX identifier. #171
Conversation
| The above copyright notice and this permission notice shall be included in | ||
| all copies or substantial portions of the Software. |
There was a problem hiding this comment.
Doesn't removal violate this requirement?
There was a problem hiding this comment.
In my opinion, no. The permission notice is still included by way of the SPDX identifier. It merely reduces the redundancy.
There was a problem hiding this comment.
SPDX is a reference to a license in an external DB, not to a notice within a license. And the requirement is to include this notice in all copies of the project.
IANAL, but I'm like 99% sure downstreams would not be able to distribute said software if it doesn't have a license file.
It's probably a good idea to ask @hroncok @befeleme @mgorny if the respective distros have policies that would cause problems.
Also, GitHub will probably stop being able to detect said licenses. It uses https://licensee.github.io/licensee/ to perform detection. You can run it as a CLI tool in a container to see what it'd return.
Keeping a separate copy of a well-known license is just extra maintenance burden. With the introduction of SPDX identifiers in PyPI metadata, the most straightforward way to indicate the license for the project is through the license metadata field.