Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the "comment" format for declaring dependencies #97

Closed
pfmoore opened this issue Jan 20, 2024 · 1 comment
Closed

Deprecate the "comment" format for declaring dependencies #97

pfmoore opened this issue Jan 20, 2024 · 1 comment
Assignees

Comments

@pfmoore
Copy link
Contributor

pfmoore commented Jan 20, 2024

Now that PEP 723 support has been added, the "comment" form of declaration:

# Requirements:
#    requests

should probably be deprecated (there's little point in having three ways of doing this).

Does this need a deprecation period, a warning, or anything like that? Presumably people using the comment format can change to PEP 723 format, but we should probably give them a better transition than a silent failure.

@jaraco
Copy link
Owner

jaraco commented Feb 8, 2024

Does this need a deprecation period, a warning, or anything like that? Presumably people using the comment format can change to PEP 723 format, but we should probably give them a better transition than a silent failure.

Yes, I think so. Fortunately, the way the precedence happens, users can put both forms in their scripts to have maximal compatibility across pip-run versions, so the deprecation period can be short.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants