New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override test_empty_username from keyring 25.3.0 for file backend #55

Merged

jaraco merged 2 commits into jaraco:main from mitya57:test-empty-username

Aug 14, 2024

Contributor

mitya57 commented Aug 10, 2024

Fixes #54.


          Override test_empty_username from keyring 25.3.0 for file backend

df66744

Fixes jaraco#54.

mitya57 mentioned this pull request

Removal of empty username support in keyring 25.3.0 breaks several tests #54

Closed


          Fix E721 (type-comparison) error from ruff

f88745f

Contributor Author

mitya57 commented Aug 10, 2024

I also fixed these ruff errors:

E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks

This in turn causes coverage error, but the change is trivial so hopefully it can be ignored.

jaraco merged commit 55cd220 into jaraco:main

12 of 14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet