Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for latest rustc #250

Merged
merged 2 commits into from
Aug 26, 2019
Merged

fix for latest rustc #250

merged 2 commits into from
Aug 26, 2019

Conversation

RalfJung
Copy link
Collaborator

Fixes xargo for rust-lang/rust#63637

@RalfJung
Copy link
Collaborator Author

Cycling PR to get CI with latest nightly including the breaking changes.

@RalfJung RalfJung requested a review from jethrogb August 25, 2019 08:50
@RalfJung
Copy link
Collaborator Author

bors try

bors bot added a commit that referenced this pull request Aug 25, 2019
@bors
Copy link
Contributor

bors bot commented Aug 25, 2019

try

Build succeeded

@RalfJung
Copy link
Collaborator Author

@jethrogb any chance you could review this? This blocks fixing Miri.

If that's okay for you, I could also do such fixes on my own in the future. I'd need owner access to xargo on crates.io, though.

@jethrogb
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request Aug 26, 2019
250: fix for latest rustc r=jethrogb a=RalfJung

Fixes xargo for rust-lang/rust#63637

251: cargo update r=jethrogb a=RalfJung



Co-authored-by: Ralf Jung <post@ralfj.de>
@bors
Copy link
Contributor

bors bot commented Aug 26, 2019

Build succeeded

@bors bors bot merged commit 2634e8f into japaric:master Aug 26, 2019
@LukasKalbertodt
Copy link

Will this be released to crates.io?
Thanks for your work!

@RalfJung
Copy link
Collaborator Author

@jethrogb if you give me crates.io permissions I can do the release. Whatever you prefer.

@jethrogb
Copy link
Collaborator

I invited you as an owner on crates.io. The release process is:

  1. Create PR bumping Cargo.toml version
  2. Get PR merged
  3. Do cargo publish on git master
  4. Add a git tag for the current version on git master, push the tag.

(This last step will automatically generate releases on GitHub)

@RalfJung RalfJung deleted the rustup branch August 26, 2019 17:34
@RalfJung
Copy link
Collaborator Author

@jethrogb is 8d1cd7c the commit you used for 0.3.15? It does not seem to have a tag, or you forgot to push it.

@jethrogb
Copy link
Collaborator

Oops, pushed to the wrong repo (https://github.com/jethrogb/xargo/releases/tag/v0.3.15)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants