-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support absolute target JSON paths #205
Conversation
|
I just realized that the PR description is a bit high level. Sorry about that! Let me explain in more detail:
I'm trying to fix rust-lang/cargo#4905 and already got a cargo PR for this merged. Target paths ending in There is one remaining issue in However, when we try
I pushed a new version that makes it clearer that only the above two things are fixed. |
rust-lang/rust#49019 was just merged and will be in the next nightly. |
The current nightly contains all necessary rustc and cargo changes, so this PR can now be tested via:
Then |
@japaric Did you have some time to look at this? This PR is the only missing piece to allow compilation without |
Given that this PR has been open for over a year now without any progress, I'm going to give it a close. For what it's worth, we use this patch in |
Builds upon rust-lang/rust#49019 and rust-lang/cargo#5228 to provide a solution to rust-lang/cargo#4905 and #194.
The idea is that we allow targets ending in
*.json
(they were forbidden before) and convert them to canonicalized paths. Thus, they just work when compiling dependencies without the need to set theRUST_TARGET_PATH
environment variable.This PR just removes the explicit prohibition of paths as target and extends
Target::new
to handle such target paths. This should not lead to any breakage, because target paths ending in.json
were explicitly forbidden before.