Allowing stable channel rustc in Rust's style #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @dingelish As you say RUSTC_BOOTSTRAP is used in the bootsrap process and it's meant to only be used there. No tool should rely on that because it's an implementation of the bootstrap process; that is RUSTC_BOOTSTRAP could disappear, or the mechanism could change at any time and that would cause your "stable" use of it to break. For that reason I'm not going to merge this PR. If you want a stable way to build a sysroot I suggest you push for stable Xargo in Cargo functionality (cf. rust-lang/cargo#4959) and notify the Cargo team (cc @aturon), who's in charge of that feature, about your need for it. |
cuviper
added a commit
to cuviper/rust
that referenced
this pull request
Mar 30, 2019
miri needs to build std with xargo, which doesn't allow stable/beta: <japaric/xargo#204 (comment)> Therefore, at this time there's no point in making miri available on any but the nightly channel. If we get a stable way to build `std`, like [RFC 2663], then we can re-evaluate whether to start including miri, perhaps still as `miri-preview`. [RFC 2663]: rust-lang/rfcs#2663
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 30, 2019
manifest: only include miri on the nightly channel miri needs to build std with xargo, which doesn't allow stable/beta: <japaric/xargo#204 (comment)> Therefore, at this time there's no point in making miri available on any but the nightly channel. If we get a stable way to build `std`, like [RFC 2663], then we can re-evaluate whether to start including miri, perhaps still as `miri-preview`. [RFC 2663]: rust-lang/rfcs#2663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-sgx-sdk author here. We are facing a problem when using xargo in production. In production, we want to use stable branch of rust to compile the sysroot to achieve stability. However, xargo doesn't allow us to do this. We found that Rust provides a switch
RUSTC_BOOTSTRAPwhich enables unstable features and allows stable branch rustc compiles latest libstd. And this option is enabled by default during bootstrap stage of building rust. So we believe thatRUSTC_BOOTSTRAPis an acceptable solution for xargo and it's a desired feature.Currently we have to maintain a branch of xargo for it. We wish it could be merged to mainstream. It's really helpful to us. Thanks!