Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonicalize issue with Xargo.toml in parent directory #259

Closed
marysaka opened this issue Oct 11, 2019 · 0 comments · Fixed by #260
Closed

Canonicalize issue with Xargo.toml in parent directory #259

marysaka opened this issue Oct 11, 2019 · 0 comments · Fixed by #260

Comments

@marysaka
Copy link
Contributor

marysaka commented Oct 11, 2019 •
edited
Loading

Since #254, xargo can search for Xargo.toml in parent directories.
However relative paths in the Xargo.toml aren't canonicalized using the correct root directory.

I made a repository to trigger the bug https://github.com/Thog/xargo_canonicalize_issue

This was tested on commit 08bf79c
@marysaka marysaka mentioned this issue Oct 11, 2019
Merged
bors bot added a commit that referenced this issue Oct 17, 2019
@bors
Merge #260
21e4808 
260: Make sure to use Xargo.toml directory when resolving path r=RalfJung a=Thog

This fix #259

Co-authored-by: Thomas Guillemard <me@thog.eu>
@bors bors bot closed this as completed in 321eee6 Oct 17, 2019
@bors bors bot closed this as completed in #260 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure to use Xargo.toml directory when resolving path marysaka/xargo
1 participant
@marysaka