Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't add episode to DB if they failed downloading (#209) #210

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

janw
Copy link
Owner

@janw janw commented Dec 3, 2024

Fixes #209.

@janw janw force-pushed the dont-add-failed-episodes-to-db branch from 07b5127 to befbac6 Compare December 3, 2024 20:35
@janw janw merged commit b61530a into main Dec 3, 2024
12 checks passed
@janw janw deleted the dont-add-failed-episodes-to-db branch December 3, 2024 20:37
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.06%. Comparing base (8f4ae3c) to head (befbac6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
podcast_archiver/processor.py 94.87% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   90.75%   91.06%   +0.31%     
==========================================
  Files          15       15              
  Lines         865      873       +8     
  Branches      160      160              
==========================================
+ Hits          785      795      +10     
+ Misses         55       54       -1     
+ Partials       25       24       -1     
Files with missing lines Coverage Δ
podcast_archiver/types.py 90.00% <100.00%> (+1.11%) ⬆️
podcast_archiver/processor.py 92.78% <94.87%> (+2.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Episode marked as downloaded even when download failed
1 participant