Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix CI error in setup-node #800

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

davidfestal
Copy link
Member

@davidfestal davidfestal commented Sep 25, 2023

Fix CI error due to the following bug:

actions/setup-node#772

This would replace PR #786 with a more correct fix (afaict).

@davidfestal davidfestal requested a review from a team as a code owner September 25, 2023 10:51
This was due to the following bug:
actions/setup-node#772

Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal force-pushed the fix-error-in-setup-node branch from 42c6bcc to 7f14bfe Compare September 25, 2023 11:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@gashcrumb gashcrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the linked issues, this does seem like a simpler workaround.

@davidfestal davidfestal merged commit 2d3ac32 into janus-idp:main Sep 25, 2023
@davidfestal davidfestal deleted the fix-error-in-setup-node branch September 25, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants