Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix, Python version deprecations, build fixes, version 1.0.0 #8

Merged
merged 12 commits into from
Oct 27, 2019

Conversation

jantman
Copy link
Owner

@jantman jantman commented Oct 27, 2019

This PR wraps up quite a few changes:

  • Fix catch all exceptions when using pip _internal? #7 where certain new versions of pip throw an AttributeError on import if running in Lambda (or other environments where sys.stdin is None).
  • Stop testing Python 3.3 and drop official support for it.
  • Stop testing Python 2.7 and 3.4.
  • Add DeprecationWarnings for any Python version < 3.5.
  • Multiple pip10 fixes.
  • Test fixes:
    • Always install latest versions of coverage and pytest.
    • Switch docs build to py37
    • Begin testing under py37 and py38

This also bumps to 1.0.0, since this has been working in the wild for quite a few years.

@codecov-io
Copy link

codecov-io commented Oct 27, 2019

Codecov Report

Merging #8 into master will increase coverage by 1.73%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #8      +/-   ##
========================================
+ Coverage   98.26%   100%   +1.73%     
========================================
  Files           4      3       -1     
  Lines         230    242      +12     
  Branches       39     38       -1     
========================================
+ Hits          226    242      +16     
+ Misses          4      0       -4
Impacted Files Coverage Δ
versionfinder/versioninfo.py 100% <ø> (ø) ⬆️
versionfinder/version.py 100% <100%> (ø) ⬆️
versionfinder/versionfinder.py 100% <100%> (+2.61%) ⬆️
versionfinder/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 773dd9c...77f9b7b. Read the comment docs.

@jantman jantman merged commit dcaa53c into master Oct 27, 2019
@jantman jantman deleted the fix-build branch October 27, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catch all exceptions when using pip _internal?
2 participants