Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove selenium and phantomjs #157

Closed
jantman opened this issue Nov 15, 2017 · 1 comment
Closed

Remove selenium and phantomjs #157

jantman opened this issue Nov 15, 2017 · 1 comment
Assignees

Comments

@jantman
Copy link
Owner

jantman commented Nov 15, 2017

Since PhantomJS seems broken on Alpine Linux, consider removing PhantomJS and Selenium from the Docker images, then updating docs on how to run them locally or in a separate container. We'd also need to add an API for wishlist2project, because that uses selenium too.

@jantman
Copy link
Owner Author

jantman commented Jan 9, 2018

Alpine Linux has chromium and chromedriver packages. It's big, 208MB installed, whereas right now our whole image is only 333MB. But it would give us a working browser inside the Docker image for wishlist and custom scraper-based ofxgetter classes.

Perhaps we should start building and publishing -chrome Docker images, built FROM the normal ones.

@jantman jantman self-assigned this Jan 10, 2018
jantman added a commit that referenced this issue Jan 10, 2018
fixes #157 - remove PhantomJS from docker image, as it's broken
@jantman jantman reopened this Jan 10, 2018
@jantman jantman closed this as completed Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant