-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove selenium and phantomjs #157
Comments
Alpine Linux has chromium and chromedriver packages. It's big, 208MB installed, whereas right now our whole image is only 333MB. But it would give us a working browser inside the Docker image for wishlist and custom scraper-based ofxgetter classes. Perhaps we should start building and publishing |
jantman
added a commit
that referenced
this issue
Jan 10, 2018
jantman
added a commit
that referenced
this issue
Jan 10, 2018
fixes #157 - remove PhantomJS from docker image, as it's broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since PhantomJS seems broken on Alpine Linux, consider removing PhantomJS and Selenium from the Docker images, then updating docs on how to run them locally or in a separate container. We'd also need to add an API for wishlist2project, because that uses selenium too.
The text was updated successfully, but these errors were encountered: