Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert budget balancing #133

Closed
3 tasks done
jantman opened this issue Oct 27, 2017 · 0 comments · Fixed by #135
Closed
3 tasks done

Revert budget balancing #133

jantman opened this issue Oct 27, 2017 · 0 comments · Fixed by #135

Comments

@jantman
Copy link
Owner

jantman commented Oct 27, 2017

Revert most of PR #127 that was opened to fix #117, end of pay period budget balancing.

I think that solution was overly complex and completely missed the point. There's really no need to balance each budget individually, and that actually does the wrong thing for pay periods that have many budgets with negative remaining values (i.e. periodic budgets with $0 budgeted but some amount spent) but still have an overall spend significantly less than income.

So, fixes for this, I think...

  • revert most of PR Issues/117 #127
  • for payperiods in the past, always calculate based on the actual spent amount, not the allocated amount
  • for balancing of payperiods, all that's needed is a manual transfer between periodic and standing, of the payperiod overall remaining amount
jantman added a commit that referenced this issue Oct 27, 2017
jantman added a commit that referenced this issue Oct 28, 2017
Issue #133 - revert Automatic Budget Balancing in #127
@jantman jantman reopened this Oct 28, 2017
@jantman jantman closed this as completed Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant