issue #142 - we should never need metadata.reflect()

jantman · Oct 31, 2017 · 3c9b380 · 3c9b380
1 parent 5745afb
commit 3c9b380
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 9 deletions.
diff --git a/biweeklybudget/tests/acceptance/flaskapp/views/test_base_template.py b/biweeklybudget/tests/acceptance/flaskapp/views/test_base_template.py
@@ -129,7 +129,6 @@ class TestBaseTmplUnreconciledNotification(AcceptanceHelper):
 
     def test_00_clean_db(self, testdb):
         # clean the database
-        biweeklybudget.models.base.Base.metadata.reflect(engine)
         biweeklybudget.models.base.Base.metadata.drop_all(engine)
         biweeklybudget.models.base.Base.metadata.create_all(engine)
 

diff --git a/biweeklybudget/tests/acceptance/flaskapp/views/test_index.py b/biweeklybudget/tests/acceptance/flaskapp/views/test_index.py
@@ -179,7 +179,6 @@ class TestIndexPayPeriods(AcceptanceHelper):
 
     def test_0_clean_db(self, testdb):
         # clean the database
-        biweeklybudget.models.base.Base.metadata.reflect(engine)
         biweeklybudget.models.base.Base.metadata.drop_all(engine)
         biweeklybudget.models.base.Base.metadata.create_all(engine)
 

diff --git a/biweeklybudget/tests/acceptance/flaskapp/views/test_payperiods.py b/biweeklybudget/tests/acceptance/flaskapp/views/test_payperiods.py
@@ -214,7 +214,6 @@ class TestPayPeriodsIndex(AcceptanceHelper):
 
     def test_0_clean_db(self, testdb):
         # clean the database
-        biweeklybudget.models.base.Base.metadata.reflect(engine)
         biweeklybudget.models.base.Base.metadata.drop_all(engine)
         biweeklybudget.models.base.Base.metadata.create_all(engine)
 
@@ -535,7 +534,6 @@ class TestPayPeriodOtherPeriodInfo(AcceptanceHelper):
 
     def test_0_clean_db(self, testdb):
         # clean the database
-        biweeklybudget.models.base.Base.metadata.reflect(engine)
         biweeklybudget.models.base.Base.metadata.drop_all(engine)
         biweeklybudget.models.base.Base.metadata.create_all(engine)
 

diff --git a/biweeklybudget/tests/acceptance/flaskapp/views/test_reconcile.py b/biweeklybudget/tests/acceptance/flaskapp/views/test_reconcile.py
@@ -212,7 +212,6 @@ def get_reconciled(self, driver):
 
     def test_00_clean_db(self, testdb):
         # clean the database
-        biweeklybudget.models.base.Base.metadata.reflect(engine)
         biweeklybudget.models.base.Base.metadata.drop_all(engine)
         biweeklybudget.models.base.Base.metadata.create_all(engine)
 
@@ -1446,7 +1445,6 @@ def get_reconciled(self, driver):
 
     def test_00_clean_db(self, testdb):
         # clean the database
-        biweeklybudget.models.base.Base.metadata.reflect(engine)
         biweeklybudget.models.base.Base.metadata.drop_all(engine)
         biweeklybudget.models.base.Base.metadata.create_all(engine)
 

diff --git a/biweeklybudget/tests/acceptance/test_biweeklypayperiod.py b/biweeklybudget/tests/acceptance/test_biweeklypayperiod.py
@@ -466,9 +466,8 @@ def test_3_ignore_scheduled_converted_to_real_trans(self, testdb):
 @pytest.mark.usefixtures('class_refresh_db', 'refreshdb')
 class TestSums(AcceptanceHelper):
 
-    def test_0_clean_db(self, testdb):
+    def test_0_clean_db(self):
         # clean the database
-        biweeklybudget.models.base.Base.metadata.reflect(engine)
         biweeklybudget.models.base.Base.metadata.drop_all(engine)
         biweeklybudget.models.base.Base.metadata.create_all(engine)
 

diff --git a/biweeklybudget/tests/conftest.py b/biweeklybudget/tests/conftest.py
@@ -158,7 +158,6 @@ def refreshdb(dump_file_path):
         conn = engine.connect()
         logger.info('Refreshing DB (session-scoped)')
         # clean the database
-        biweeklybudget.models.base.Base.metadata.reflect(engine)
         biweeklybudget.models.base.Base.metadata.drop_all(engine)
         biweeklybudget.models.base.Base.metadata.create_all(engine)
         # load the sample data