Add support for EBS st1 and sc1 volume types.

[gimballock]

Feature Request

Currently I see the following error when running limit checker:
"ERROR:awslimitchecker.services.ebs:ERROR - unknown volume type 'st1' for volume vol-xxxxxxxx; not counting"

These volume types are fairly recent and the source looks pretty simple to extend. I will attempt to provide a PR for this fix..

[jantman]

@gimballock thanks for the heads up. No worry about a PR unless you want to, I should be able to get this done this afternoon or this evening.

[gimballock]

FYI These aren't yet supported in TA yet so I picked some limit labels in
the meantime:
'Throughput Optimized (HDD) volume storage (GiB)'
'Cold (HDD) volume storage (GiB)'

On Mon, Jun 27, 2016 at 7:52 AM, Jason Antman notifications@github.com
wrote:

@gimballock https://github.com/gimballock thanks for the heads up. No
worry about a PR unless you want to, I should be able to get this done this
afternoon or this evening.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#189 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AD5LGHhHEQJdXigYp13yshEPNu-fWdCUks5qP-O0gaJpZM4I-po6
.

[jantman]

@gimballock these limits are listed in the "Limits" page on the EC2 console (not that that's an indication of what TA will call them:

"Max Cold HDD (SC1) Storage in TiB" and "Max Throughput Optimized HDD (ST1) Storage in TiB" (though the API reports in GB, and that's what all of the limit checker stuff uses.

Did you want to try your hand at a PR, or should I work on the changes? It turns out my schedule is a bit more busy than I'd thought, and tomorrow evening is probably more likely for a fix and release.

[gimballock]

Yea I'll send you a PR, I have it ready except for these label name changes.

On Mon, Jun 27, 2016 at 3:01 PM, Jason Antman notifications@github.com
wrote:

@gimballock https://github.com/gimballock these limits are listed in
the "Limits" page on the EC2 console (not that that's an indication of what
TA will call them:

"Max Cold HDD (SC1) Storage in TiB" and "Max Throughput Optimized HDD
(ST1) Storage in TiB" (though the API reports in GB, and that's what all of
the limit checker stuff uses.

Did you want to try your hand at a PR, or should I work on the changes? It
turns out my schedule is a bit more busy than I'd thought, and tomorrow
evening is probably more likely for a fix and release.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#189 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AD5LGOjq8m75Zb1lzZyQk0pbAnG4fIiAks5qQEgxgaJpZM4I-po6
.

[gimballock]

Actually are you sure you want to use 'Max' and (<vol_type>) in the label?
The labels I have now are more inline with existing labels:
'Provisioned IOPS (SSD) storage (GiB)'
'General Purpose (SSD) volume storage (GiB)'
'Magnetic volume storage (GiB)'
'Throughput Optimized (HDD) volume storage (GiB)'
'Cold (HDD) volume storage (GiB)'

On Mon, Jun 27, 2016 at 4:16 PM, Eric Price gimballock@gmail.com wrote:

Yea I'll send you a PR, I have it ready except for these label name
changes.

On Mon, Jun 27, 2016 at 3:01 PM, Jason Antman notifications@github.com
wrote:

@gimballock https://github.com/gimballock these limits are listed in
the "Limits" page on the EC2 console (not that that's an indication of what
TA will call them:

"Max Cold HDD (SC1) Storage in TiB" and "Max Throughput Optimized HDD
(ST1) Storage in TiB" (though the API reports in GB, and that's what all of
the limit checker stuff uses.

Did you want to try your hand at a PR, or should I work on the changes?
It turns out my schedule is a bit more busy than I'd thought, and tomorrow
evening is probably more likely for a fix and release.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#189 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AD5LGOjq8m75Zb1lzZyQk0pbAnG4fIiAks5qQEgxgaJpZM4I-po6
.

[jantman]

Ok, yours look fine to me. There's already a built-in way of mapping limits that have different names in Trusted Advisor (since TA always runs late...)

Thanks!

[jantman]

This was fixed in #190 and released just now as 0.4.4. Thanks!!!!