Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

train_alignn.py add wandb tracking and avoid POSCARs on disk #45

Merged
merged 6 commits into from
Jul 11, 2023

Conversation

janosh
Copy link
Owner

@janosh janosh commented Jul 8, 2023

This is a similar refactor of models/alignn/train_alignn.py using pymatgen.io.jarvis.JarvisAtomsAdaptor to avoid the need to export MP/WBM structures to POSCAR as 20f76dd was for models/alignn/test_alignn.py.

It also adds wandb tracking.

@pbenner If you have time (no pressure) let me know if this script is running for you. It requires minor changes in usnistgov/alignn#124 to run.

@janosh janosh added enhancement New feature or request help wanted Extra attention is needed data Data loading and processing labels Jul 8, 2023
@janosh janosh temporarily deployed to github-pages July 8, 2023 17:53 — with GitHub Actions Inactive
@janosh janosh temporarily deployed to github-pages July 8, 2023 22:49 — with GitHub Actions Inactive
@janosh janosh temporarily deployed to github-pages July 8, 2023 22:56 — with GitHub Actions Inactive
@janosh janosh temporarily deployed to github-pages July 9, 2023 03:50 — with GitHub Actions Inactive
janosh added 2 commits July 10, 2023 17:17
submodule not actually needed
@janosh janosh temporarily deployed to github-pages July 11, 2023 00:24 — with GitHub Actions Inactive
@janosh janosh merged commit 7f9ce4f into main Jul 11, 2023
@janosh janosh deleted the alignn-train-refactor branch July 11, 2023 01:14
janosh added a commit that referenced this pull request Jul 11, 2023
* train_alignn.py add wandb tracking and refactor to not need POSCARs on disk

* remove debug line

* bump elementari

* NERSC tweaks

* fix test_slurm

* git rm paper (git submodule not actually needed)
@pbenner
Copy link
Collaborator

pbenner commented Jul 11, 2023

Yep, the script works here!

@janosh
Copy link
Owner Author

janosh commented Jul 11, 2023

Perfect! Thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Data loading and processing enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants