fix metrics tables regression/classification dotted divider line

and make it dynamic based on MAE col idx ti prevent future errors
janosh · Aug 16, 2023 · b4e9da3 · b4e9da3
1 parent 62b701c
commit b4e9da3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/scripts/model_figs/make_metrics_tables.py b/scripts/model_figs/make_metrics_tables.py
@@ -138,12 +138,15 @@
     styler.set_uuid("")
 
     # export model metrics as styled HTML table and Svelte component
-    # draw dotted line between classification and regression metrics
+    # get index of MAE column
+    mae_col_idx = styler.columns.get_loc("MAE")
+    css_col_selector = f"#T_ :is(td, th):nth-child({mae_col_idx + 2})"
     df_to_svelte_table(
         styler,
         f"{SITE_FIGS}/metrics-table{label}.svelte",
         inline_props="class='roomy'",
-        styles="#T_ :is(td, th):nth-last-child(4) { border-left: 1px dotted white; }",
+        # draw dotted line between classification and regression metrics
+        styles=f"{css_col_selector} {{ border-left: 1px dotted white; }}",
     )
     try:
         df_to_pdf(styler, f"{PDF_FIGS}/metrics-table{label}.pdf")

diff --git a/site/src/figs/metrics-table-first-10k.svelte b/site/src/figs/metrics-table-first-10k.svelte
diff --git a/site/src/figs/metrics-table.svelte b/site/src/figs/metrics-table.svelte