Generate correct source map if hermes not enabled (facebook#25700)

janicduplessis · Jul 18, 2019 · 9a418d3 · 9a418d3
1 parent 856b438
commit 9a418d3
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/react.gradle b/react.gradle
@@ -126,11 +126,11 @@ afterEvaluate {
             if (Os.isFamily(Os.FAMILY_WINDOWS)) {
                 commandLine("cmd", "/c", *nodeExecutableAndArgs, cliPath, bundleCommand, "--platform", "android", "--dev", "${devEnabled}",
                     "--reset-cache", "--entry-file", entryFile, "--bundle-output", jsBundleFile, "--assets-dest", resourcesDir,
-                    "--sourcemap-output", jsPackagerSourceMapFile, *extraArgs)
+                    "--sourcemap-output", enableHermes ? jsPackagerSourceMapFile : jsOutputSourceMapFile, *extraArgs)
             } else {
                 commandLine(*nodeExecutableAndArgs, cliPath, bundleCommand, "--platform", "android", "--dev", "${devEnabled}",
                     "--reset-cache", "--entry-file", entryFile, "--bundle-output", jsBundleFile, "--assets-dest", resourcesDir,
-                    "--sourcemap-output", jsPackagerSourceMapFile, *extraArgs)
+                    "--sourcemap-output", enableHermes ? jsPackagerSourceMapFile : jsOutputSourceMapFile, *extraArgs)
             }
 
             if (enableHermes) {
@@ -167,13 +167,6 @@ afterEvaluate {
                         }
                     }
                 }
-            } else {
-                doLast {
-                    ant.move(
-                        file: jsPackagerSourceMapFile,
-                        tofile: jsOutputSourceMapFile
-                    );
-                }
             }
 
             enabled config."bundleIn${targetName}" != null