Skip to content

Commit

Permalink
Revert "Quote --sourcemap-output argument during ios build (facebook#…
Browse files Browse the repository at this point in the history
…31587)"

This reverts commit f3fe7a0.
  • Loading branch information
janicduplessis committed Oct 21, 2021
1 parent a4835c3 commit 310de04
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions scripts/react-native-xcode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ fi

BUNDLE_FILE="$CONFIGURATION_BUILD_DIR/main.jsbundle"

EXTRA_ARGS=()
EXTRA_ARGS=

case "$PLATFORM_NAME" in
"macosx")
Expand All @@ -139,12 +139,12 @@ if [[ $EMIT_SOURCEMAP == true ]]; then
else
PACKAGER_SOURCEMAP_FILE="$SOURCEMAP_FILE"
fi
EXTRA_ARGS+=("--sourcemap-output" "$PACKAGER_SOURCEMAP_FILE")
EXTRA_ARGS="$EXTRA_ARGS --sourcemap-output $PACKAGER_SOURCEMAP_FILE"
fi

# Hermes doesn't require JS minification.
if [[ $USE_HERMES == true && $DEV == false ]]; then
EXTRA_ARGS+=("--minify" "false")
EXTRA_ARGS="$EXTRA_ARGS --minify false"
fi

# PRODUCT_SETTINGS_PATH is where the target Info.plist file is. The asset
Expand All @@ -160,8 +160,8 @@ ASSET_CATALOG_DEST=${ASSET_CATALOG_DEST:-"$(dirname "$PRODUCT_SETTINGS_PATH")"}
--bundle-output "$BUNDLE_FILE" \
--assets-dest "$DEST" \
--asset-catalog-dest "$ASSET_CATALOG_DEST" \
"${EXTRA_ARGS[@]}" \
"${EXTRA_PACKAGER_ARGS[@]}"
$EXTRA_ARGS \
$EXTRA_PACKAGER_ARGS

if [[ $USE_HERMES != true ]]; then
cp "$BUNDLE_FILE" "$DEST/"
Expand Down

0 comments on commit 310de04

Please sign in to comment.