Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cortex to the latest version 1.0.10-rc1 to address hardware UI issues #4622

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

louis-menlo
Copy link
Contributor

@louis-menlo louis-menlo commented Feb 11, 2025

Descriptions

This PR addressed following issues of the current Jan v0.5.15-rc7-beta:

  1. cortex.cpp returns a default fallback GPU information with 0 total VRAM size when the machine has no dedicated GPUs plugged in.
  2. App shows NaN GPU information due to a quick fix to patch the issue above (to filter out 0 vram GPUs)
  3. App shows empty selected engine variant since it thought there is a NVidia GPU plugged in
    This pull request includes several changes to the GPU-related types and their usage in the codebase. The main changes involve making the additional_information field optional and updating the corresponding logic to handle this change.

Changes to GPU-related types:

Import adjustments:

Logic updates:

UI adjustments:

@louis-menlo louis-menlo requested a review from urmauur February 11, 2025 02:38
@github-actions github-actions bot added the type: chore Maintenance, operational label Feb 11, 2025
@louis-menlo
Copy link
Contributor Author

There is still an ongoing investigation into determining which GPU driver, such as CUDA, Vulkan

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Barecheck - Code coverage report

Total: 67.75%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-menlo louis-menlo merged commit ceb93ca into release/v0.5.15 Feb 11, 2025
10 checks passed
@louis-menlo louis-menlo deleted the chore/bump-cortex-to-1.0.10-rc1 branch February 11, 2025 03:24
@github-actions github-actions bot added this to the v0.5.15 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants