Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add back app logging function #4614

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

louis-menlo
Copy link
Contributor

This pull request adds back logging function to the application. It includes adding a FileLogger class for logging to files and integrating this logger into the application startup process. (previously implemented from monitoring extension, the extension is now removed)

CleanShot 2025-02-09 at 18 44 10@2x
CleanShot 2025-02-09 at 18 44 17@2x
CleanShot 2025-02-09 at 18 44 53@2x

Logging Enhancements:

  • New File Logger Implementation:

    • Added a FileLogger class in electron/utils/logger.ts to handle logging to files, including methods for logging messages and cleaning old logs.
  • Register Logger:

    • Imported the registerLogger function in electron/main.ts and added it to the application startup sequence to initialize the logger. [1] [2]

@github-actions github-actions bot added the type: chore Maintenance, operational label Feb 9, 2025
@louis-menlo louis-menlo requested a review from urmauur February 9, 2025 11:50
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Barecheck - Code coverage report

Total: 67.74%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

github-actions bot commented Feb 9, 2025

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-menlo louis-menlo merged commit 05b124f into release/v0.5.15 Feb 9, 2025
21 checks passed
@louis-menlo louis-menlo deleted the chore/add-back-app-logging-function branch February 9, 2025 12:36
@github-actions github-actions bot added this to the v0.5.15 milestone Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants