Fix inclusion of makedev in Linux on glibc 2.26 #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While using core.v0.11.1 with the 4.06.1 release of ocaml, installed via opam on a Gentoo Linux install with glibc 2.26, linking of ocaml binaries fails with: [...]/.opam/4.06.1/lib/core/libcore_stubs.a(unix_stubs.o): In function `unix_mknod_stub': [...]/.opam/4.06.1/build/core.v0.11.1/_build/default/src/unix_stubs.c:281: undefined reference to `makedev' collect2: error: ld returned 1 exit status File "caml_startup", line 1: Error: Error during linking Command exited with code 2. Glibc had traditionally supported the BSD way of including makedev via <sys/types.h>, but 2.25 has deprecated this behavior. The macro is now imported via <sys/sysmacros.h>. I have tested compilation of this patch both on Linux and MacOS 10.13, but on top of the v0.11 branch; master is broken for me due to #110. I have replaced the libcore_stubs.a in my opam installation with the fixed one, and the 'undefined reference' error disappeared. Signed-off-by: Marco Leogrande <dark.knight.ita@gmail.com>
|
Thanks, I added this patch to our internal review system |
Closed
|
Sorry, we normally have a system to track changes that come from github so that we remember to click the merge button on github, but I missed a step in the process. This change has now been integrated internally and was pushed back to github. |
ghost
closed this
|
No problem, thanks for approving the change! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using core.v0.11.1 with the 4.06.1 release of ocaml, installed
via opam on a Gentoo Linux install with glibc 2.26, linking of ocaml
binaries fails with:
Glibc had traditionally supported the BSD way of including makedev via
<sys/types.h>, but 2.25 has deprecated this behavior. The macro is now
imported via <sys/sysmacros.h>.
I have tested compilation of this patch both on Linux and MacOS 10.13,
but on top of the v0.11 branch; master is broken for me due to #110. I
have replaced the libcore_stubs.a in my opam installation with the
fixed one, and the 'undefined reference' error disappeared.
Signed-off-by: Marco Leogrande dark.knight.ita@gmail.com