Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brackets in values, kill parsing #3

Closed
JayWood opened this issue May 20, 2015 · 4 comments
Closed

Brackets in values, kill parsing #3

JayWood opened this issue May 20, 2015 · 4 comments

Comments

@JayWood
Copy link

JayWood commented May 20, 2015

Ran into this today, no fix as of yet, but we have a json feed which has occasionally brackets inside of the data sets.

Example
[ { "cLabel": "$69} for Carpet Cleaning for Three Rooms ($405 Value)." }, { "cLabel": "This is a good label" } ]

The first cLabel will think it's closed after $69} and not return a valid json object. I only ran into this with the curly brace, I would assume square brackets have the same issue looking at the STATE_INSQUARE condition in JSONCharInputReader::readChar()

I would think we can check if we're in a string when we're also checking for brackets?

@janeklb
Copy link
Owner

janeklb commented May 20, 2015

Thanks for raising the issue - this is definitely a huge shortcoming of the parser. I'll have a look at it asap

janeklb pushed a commit that referenced this issue May 20, 2015
janeklb pushed a commit that referenced this issue May 21, 2015
@janeklb
Copy link
Owner

janeklb commented May 21, 2015

Fixed in 0.3.2!

@jtsternberg
Copy link

Thank you @janeklb!

@JayWood
Copy link
Author

JayWood commented May 21, 2015

Thank you so much @janeklb you've saved me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants