Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate dependency entries #10

Closed
janbiasi opened this issue Nov 29, 2023 · 1 comment · Fixed by #11
Closed

Duplicate dependency entries #10

janbiasi opened this issue Nov 29, 2023 · 1 comment · Fixed by #11
Assignees
@janbiasi
Labels
🐛 bug Something isn't working as expected or stated stale Stale issues without communication
Milestone
V1

Comments

@janbiasi
Copy link
Owner

At the moment, certain dependencies - if imported multiple times - are listed more than once in the components section. We might want to add a condition if a certain component already is registered and omit the potential duplicates.
@janbiasi janbiasi added the 🐛 bug Something isn't working as expected or stated label Nov 29, 2023
@janbiasi janbiasi added this to the V1 milestone Nov 29, 2023
@janbiasi janbiasi self-assigned this Nov 29, 2023
janbiasi added a commit that referenced this issue Nov 30, 2023
@janbiasi
fix: only register dependencies once, fixes #10
3052ce6
@janbiasi janbiasi mentioned this issue Nov 30, 2023
Merged
2 tasks
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues without communication label Dec 30, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2024
@janbiasi janbiasi reopened this Feb 23, 2024
janbiasi added a commit that referenced this issue Feb 24, 2024
@janbiasi
fix: only register dependencies once, fixes #10
e1edf47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbiasi janbiasi

Labels
🐛 bug Something isn't working as expected or stated stale Stale issues without communication
Projects
None yet
Milestone
V1
Development

Successfully merging a pull request may close this issue.

Add tests janbiasi/rollup-plugin-sbom
1 participant
@janbiasi