Style Guide updates for Client, Server #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilgongo
changed the title
Hm. |
|
That error is because the po4a .deb package has been updated in the assets repo, but the GH action won't point to it properly until #873 is merged. |
mcfnord
reviewed
Dec 10, 2022
contribute/en/Style-and-Tone.md
Outdated
| @@ -89,9 +89,11 @@ Jamulus is “Free and Open Source (FOSS)” (not “free software” or “open | |||
|
|
|||
| “Person” A human connected to a server (may be on multiple channels). “People on the server”, “People who have muted themselves” (not “Musicians” or "Channels"). | |||
There was a problem hiding this comment.
A connection would be a "fader" according to the guide. We wanted to use "person" because one person may have a number of faders on the server, and "fader" should be unambiguous because that's what you see in the UI (and it;s most likely to be what you're interested in eg, muting, volume, ordering).
mcfnord
reviewed
Dec 18, 2022
mcfnord
reviewed
Dec 19, 2022
mcfnord
reviewed
Dec 19, 2022
mcfnord
reviewed
Dec 19, 2022
mcfnord
reviewed
Dec 19, 2022
mcfnord
reviewed
Dec 19, 2022
Co-authored-by: John Dempsey <1750243+mcfnord@users.noreply.github.com>
Co-authored-by: John Dempsey <1750243+mcfnord@users.noreply.github.com>
Co-authored-by: John Dempsey <1750243+mcfnord@users.noreply.github.com>
Co-authored-by: John Dempsey <1750243+mcfnord@users.noreply.github.com>
Co-authored-by: John Dempsey <1750243+mcfnord@users.noreply.github.com>
ann0see
approved these changes
Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the style guide for the recent change to use capitalisation for some special Jamulus terms.
Not updated this for a while - assuming it goes straight to release?