-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server UI Changes #677
Server UI Changes #677
Conversation
I'll wait a bit for the main PR to mature before updating the screenshots. |
OK so pending the outcome of jamulussoftware/jamulus#2228 vocabulary we go for, I've done all the changes save for the screenshots now. |
321ad03
to
fd7c6a3
Compare
Not sure what to do with this PR. |
I can try fixing the conflicts. Otherwise, I think it's OK. I think we agree that we can't prevent people from using the term "private", but if we try to be clear with our terms in the docs then that's all we can do. |
BTW I'm going to do another PR to turn the structure of the server docs inside out so that they lead (after suitable intro) with running a headless Linux server. So I'd like to get this merged :-) |
Actually, no I can't as I don't know what all those |
Hmm. I think fixing the conflicts is a tricky one... @ignotus666 I think it makes sense to do it the "dirty" way i.e. just copy the changed files manually to a new branch |
Yeah, it seems that lots of the changes in files are stuff that has nothing to do with "server UI changes" (image links edited to use includes, etc.). There might still be conflicts in some files because small things may have got edited since this PR was created, but they'll be much easier to fix than what's here now. The .po and .inc file conflicts should go away anyway. |
OK so if I close this. What's the best way of working out what I changed? Maybe I can just remember what those files were. I think it was only a few. |
The list of changed files in this PR should tell you (just ignore all the. po and .inc files). |
Does this need translation?
Changes
A number of changes across the docs are implied by changes to the server UI (notably, but not exclusively, the abolition of the concept of "private servers") in jamulussoftware/jamulus#2199
See also the discussion on vocabulary here: jamulussoftware/jamulus#2228