Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke test update notice #1079

Open
wants to merge 1 commit into
base: next-release
Choose a base branch
from

Conversation

pljones
Copy link
Contributor

@pljones pljones commented Dec 25, 2024

Short description of changes
Adds details of how to smoke test the update notification to the release checklist template.

Context: Fixes an issue? Related issues
Fixes: 1045

Status of this Pull Request
Should be okay.

What is missing until this pull request can be merged?
Review

Does this need translation?
Don't think so.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I'm sure that this Pull Request goes to the correct branch

@pljones pljones changed the base branch from release to next-release December 25, 2024 09:45
@pljones pljones added this to the Release 3.12.0 milestone Dec 25, 2024
@pljones pljones self-assigned this Dec 25, 2024
- [ ] Do a smoke test for Windows/Mac/Linux
- [ ] Do the binaries start/connect properly?
- [ ] Can earlier Jamulus versions properly connect to a server based on the new release?
- [ ] Do a smoke test of the upgrade notification (do this _very quickly_)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any better way to test this instead of testing in production?

Copy link
Contributor Author

@pljones pljones Dec 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the point is to check that an old version does find the production update.

@pljones pljones force-pushed the smoke-test-update-notice branch from 9b1fa06 to 899851c Compare December 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on Team
Development

Successfully merging this pull request may close these issues.

Smoke test should include checking update notification appears for earlier version
2 participants