Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ENV Support for server config setting SupplyDropSpan #280

Conversation

KyleDiao
Copy link

FR #279 added env SUPPLY_DROP_SPAN in doc and default config

this config exsist in DefaultPalWorldSettings.ini , with default value 180(min)

this commit add the support for change this config via ENV vars like other config settings.

@jammsen
Copy link
Owner

jammsen commented Aug 14, 2024

Hello @KyleDiao - Please add also an entry to the changelog.md in the root directory with the reference after the description to (#279) - (The PR and Changelog should always point to an issue and not to iself, thats why im asking for #279)

After that im happy to merge this to deveop to be tested.

@KyleDiao
Copy link
Author

Hi @jammsen , sorry for the missing, I've added the changelog entry.

@jammsen jammsen merged commit ffc5bdd into jammsen:develop Aug 15, 2024
@jammsen
Copy link
Owner

jammsen commented Aug 15, 2024

Thanks for the contributuion, you can in about 5 minutes use the jammsen/palworld-dedicated-server:develop tag to test things out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants