Skip to content

Commit

Permalink
Bug 1749414 [wpt PR 32319] - Fix modal-dialog-scroll-height.html, a=t…
Browse files Browse the repository at this point in the history
…estonly

Automatic update from web-platform-tests
Fix modal-dialog-scroll-height.html

This test is failing in all browsers on wpt.fyi due to the hard coded
height:
https://wpt.fyi/results/html/semantics/interactive-elements/the-dialog-element/modal-dialog-scroll-height.html

I'm not sure why it passes in the chromium test infrastructure, but
people want to remove it:
web-platform-tests/interop#12 (comment)

This patch replaces the hard coded height with window.innerHeight.

Change-Id: If27a4b07ca235190d19cbe2f52bbfe6dd2594225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3379191
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#958207}

--

wpt-commits: 7915bc605347950da0a0af3707a788048a08ff3c
wpt-pr: 32319
  • Loading branch information
josepharhar authored and moz-wptsync-bot committed Feb 5, 2022
1 parent 89700b7 commit 87f60b4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@
<script>
test(() => {
document.querySelector('dialog').showModal();
assert_equals(document.scrollingElement.scrollHeight, 600);
assert_equals(document.scrollingElement.scrollHeight, window.innerHeight);
}, 'dialogs should be centered before computing overflow.');
</script>

0 comments on commit 87f60b4

Please sign in to comment.