Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need py.typed file for type annotations to work #165

Closed
jamielennox opened this issue Apr 28, 2021 · 0 comments · Fixed by #166
Closed

Need py.typed file for type annotations to work #165

jamielennox opened this issue Apr 28, 2021 · 0 comments · Fixed by #166

Comments

@jamielennox
Copy link
Owner

The initial PR had a py.typed file that is necessary for annotations to work https://www.python.org/dev/peps/pep-0561/#packaging-type-information

It was removed in a subsequent commit: #163

This means release 1.9.0 doesn't provide the type features it is supposed to.
jamielennox added a commit that referenced this issue Apr 28, 2021
@jamielennox
Restore py.typed file to enable types
42fa34e 
Without this type annotations aren't picked up. This should not have
been deleted.

https://www.python.org/dev/peps/pep-0561/#packaging-type-information

Closes: #165
@jamielennox jamielennox mentioned this issue Apr 28, 2021
Merged
jamielennox added a commit that referenced this issue Apr 28, 2021
@jamielennox
Restore py.typed file to enable types
78ef2d0 
Without this type annotations aren't picked up. This should not have
been deleted.

https://www.python.org/dev/peps/pep-0561/#packaging-type-information

Closes: #165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore py.typed file to enable types jamielennox/requests-mock
1 participant
@jamielennox