Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor copy edits #92

Merged
merged 6 commits into from
May 6, 2023
Merged

Minor copy edits #92

merged 6 commits into from
May 6, 2023

Conversation

smasongarrison
Copy link
Contributor

Here's the pull request with the minor copy edits I made while reviewing your paper. Nice job!

@jamesuanhoro
Copy link
Owner

Thank you again @smasongarrison for the changes here, they are much appreciated. Just updating the README.md file based on your changes to the README.Rmd prior to committing.

@smasongarrison smasongarrison marked this pull request as ready for review May 6, 2023 14:12
@jamesuanhoro jamesuanhoro merged commit ce994f0 into jamesuanhoro:master May 6, 2023
@smasongarrison
Copy link
Contributor Author

Happy to help! Genuinely, the process of peer reviewing was very helpful. It's gotten me thinking about doing the final push for a few of my own packages. I'll be curious how your department views JOSS papers.

@jamesuanhoro
Copy link
Owner

Yeah, it's a very nice process. Funny: I had my annual review meeting with my dept. chair and wanted to ask this question, then completely forgot, lol. I think I'll email her instead. JOSS lets you retrieve paper metrics so hoping that works for the department.

@smasongarrison
Copy link
Contributor Author

Lol. I was able to negotiate for software packages (as long as I maintained them) to count as research in my annual reviews. They're a little overpowered at the moment, so I've been thinking about how to nerf them. And JOSS might be a way to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants