Optionally inherit wheelchair boarding from parent station #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late response, I was away traveling for a few weeks! PR looks good with one small comment. |
static.go
Outdated
| @@ -149,7 +149,15 @@ type Frequency struct { | |||
| ExactTimes ExactTimes | |||
| } | |||
|
|
|||
| type ParseStaticOptions struct{} | |||
| type StopOptions struct { | |||
There was a problem hiding this comment.
should we just put the InheritWheelchair boarding field directly on the ParseStaticOptions struct, and remove the StopOptions struct? I feel it's unambiguous there, I may be wrong though
There was a problem hiding this comment.
I think that makes sense - I've removed the StopOptions struct.
jamespfennell
approved these changes
Sep 17, 2024
cedarbaum
force-pushed
the
inherit_wheelchair_boarding
branch
from
e15b8d4
to
51bde3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to inheriting
wheelchair_boardingfrom parent station when not specified for a child stop/platform/entrance/exit.