Add support for 16-bit and 8-bit architectures #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
|
Alright, I tested it now, it works perfectly on the ATmega328P, both serialization and deserialization. I have no reason to believe it won't work for 16-bit either :) |
|
Awesome,thank you! As a note, although the atmegas are 8-bit CPUs, they have 16-bit pointers (and 16-bit usizes). I'm almost certain Rust wouldn't work with 8-bit pointers, but hey, I'll keep it just in case :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, the ATmega328P I'm using right now has an 8-bit architecture. It seems this change is all that's needed to make postcard work on that MC, but I'll add a comment once I actually tried it out.