Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nalgebra schema #188

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix nalgebra schema #188

merged 1 commit into from
Nov 27, 2024

Conversation

max-heller
Copy link
Collaborator

Closes #181, using a slice-of-array flattening function borrowed from the const-unstable <[[T; N]]>::as_flattened()

Copy link

netlify bot commented Nov 24, 2024

Deploy Preview for cute-starship-2d9c9b canceled.

Name Link
🔨 Latest commit 5edcc9a
🔍 Latest deploy log https://app.netlify.com/sites/cute-starship-2d9c9b/deploys/674320ec9b5e780008bfeea8

@jamesmunns
Copy link
Owner

Oh this is DEVIOUS. I was ready to come in and say that &[T] isn't the same as &[T; N], but I didn't even THINK of doing shenanigans like this only on the schema.

I want to poke around at this, but this is extremely clever, thank you!

@jamesmunns jamesmunns merged commit fae27b3 into jamesmunns:main Nov 27, 2024
5 checks passed
@max-heller max-heller deleted the nalgebra branch December 23, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postcard-schema: nalgebra schema is incorrect
2 participants