Fix clippy lints #150
Merged
Fix clippy lints #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
ia0
commented
May 13, 2024
| #[cfg(feature = "experimental-derive")] | ||
| pub mod schema; | ||
| pub(crate) mod schema; |
There was a problem hiding this comment.
This is partially reverting #134 because I don't think the intent was to expose schema publicly until it goes out of experimental. The warning here was about documentation, which should be duplicated if we want to control the visibility from the cfg.
There was a problem hiding this comment.
I will likely intend to take this out of experimental with #128 coming up soon, so it works for me.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to choose the most obvious fix for each warning, but sometimes it might be arguable. I'll try to point out those cases. Feel free to suggest alternatives if needed.