Define MaxSize for Arc and Rc #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
|
Thank you! |
|
Thanks for merging this in @jamesmunns! Anything I can do to help release 1.0.9? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serde supports auto-deriving Serialize and Deserialize for Arc and Rc types with the caveat being that the underlying type is serialized/deserialized. I am using this feature along with Postcard, and need this patch (or something equivalent to it) in order to calculate the max serialized size of my types.
More details on Serde's Arc and Rc support here: https://serde.rs/feature-flags.html#rc