Introduce ReviewStatus enum and update RequestReview method #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new enumeration `ReviewStatus` has been introduced in the `Plugin.StoreReview` namespace, including values `Succeeded`, `Error`, `CanceledByUser`, `NetworkError`, and `Unknown`. The `RequestReview(bool testMode)` method in multiple files has been modified to return a `Task<ReviewStatus>` instead of a `Task`. This method has been updated in `StoreReviewImplementation.android.cs` to return either `ReviewStatus.Succeeded` or `ReviewStatus.Error` based on the `status` variable, in `StoreReviewImplementation.apple.cs` to return `ReviewStatus.Unknown`, and in `StoreReviewImplementation.uwp.cs` to use the `StoreContext.GetDefault().RequestRateAndReviewAppAsync()` method and return a `ReviewStatus` based on the result. Additional `using` directives have been added to the `StoreReviewImplementation.uwp.cs` file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
A new enumeration
ReviewStatushas been introduced in thePlugin.StoreReviewnamespace, including valuesSucceeded,Error,CanceledByUser,NetworkError, andUnknown. TheRequestReview(bool testMode)method in multiple files has been modified to return aTask<ReviewStatus>instead of aTask. This method has been updated inStoreReviewImplementation.android.csto return eitherReviewStatus.SucceededorReviewStatus.Errorbased on thestatusvariable, inStoreReviewImplementation.apple.csto returnReviewStatus.Unknown, and inStoreReviewImplementation.uwp.csto use theStoreContext.GetDefault().RequestRateAndReviewAppAsync()method and return aReviewStatusbased on the result. Additionalusingdirectives have been added to theStoreReviewImplementation.uwp.csfile.###