Skip to content

Commit

Permalink
Update to official nuget
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesmontemagno committed Jun 9, 2023
1 parent 906a60e commit d1035ac
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions src/StoreReview.Plugin/StoreReview.Plugin.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="MSBuild.Sdk.Extras/3.0.44">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;MonoAndroid10.0;Xamarin.iOS10;Xamarin.TVOS10;Xamarin.Mac20;net6.0-android;net6.0-ios;net6.0-maccatalyst</TargetFrameworks>
<TargetFrameworks>netstandard2.0;MonoAndroid12.0;Xamarin.iOS10;Xamarin.TVOS10;Xamarin.Mac20;net6.0-android;net6.0-ios;net6.0-maccatalyst</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);uap10.0.19041;net6.0-windows10.0.19041;</TargetFrameworks>
<AssemblyName>Plugin.StoreReview</AssemblyName>
<RootNamespace>Plugin.StoreReview</RootNamespace>
Expand Down Expand Up @@ -95,12 +95,12 @@

<ItemGroup Condition=" $(TargetFramework.Contains('-android')) ">
<Compile Include="**\*.android.cs" />
<PackageReference Include="PlayCore" Version="1.10.2-rc2" />
<PackageReference Include="Xamarin.Google.Android.Play.Core" Version="1.10.3.5" />
</ItemGroup>

<ItemGroup Condition=" $(TargetFramework.StartsWith('MonoAndroid')) ">
<Compile Include="**\*.android.cs" />
<PackageReference Include="PlayCore" Version="1.10.2-rc2" />
<PackageReference Include="Xamarin.Google.Android.Play.Core" Version="1.10.3.5" />
<PackageReference Include="Xamarin.Essentials" Version="1.7.3" />
</ItemGroup>

Expand Down
14 changes: 7 additions & 7 deletions src/StoreReview.Plugin/StoreReviewImplementation.android.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
using Android.Content;
using Android.OS;
using Android.Runtime;
using Com.Google.Android.Play.Core.Review;
using Com.Google.Android.Play.Core.Review.Testing;
using Com.Google.Android.Play.Core.Tasks;
using Plugin.StoreReview.Abstractions;
using System;
using System.Threading.Tasks;
using Task = System.Threading.Tasks.Task;
using Xamarin.Google.Android.Play.Core.Tasks;
using Xamarin.Google.Android.Play.Core.Review;
using Xamarin.Google.Android.Play.Core.Review.Testing;

#if NET
using Microsoft.Maui.ApplicationModel;
Expand Down Expand Up @@ -105,11 +105,11 @@ public async Task RequestReview(bool testMode)
}

Activity Activity =>
Platform.CurrentActivity ?? throw new NullReferenceException("Current Activity is null, ensure that the MainActivity.cs file is configuring Essentials in your source code so the In App Billing can use it.");
Platform.CurrentActivity ?? throw new NullReferenceException("Current Activity is null, ensure that the MainActivity.cs file is configuring Essentials in your source code so the StoreReview can use it.");

bool forceReturn;
Com.Google.Android.Play.Core.Tasks.Task launchTask;
public void OnComplete(Com.Google.Android.Play.Core.Tasks.Task task)
Xamarin.Google.Android.Play.Core.Tasks.Task launchTask;
public void OnComplete(Xamarin.Google.Android.Play.Core.Tasks.Task task)
{
if (!task.IsSuccessful || forceReturn)
{
Expand All @@ -131,5 +131,5 @@ public void OnComplete(Com.Google.Android.Play.Core.Tasks.Task task)
System.Diagnostics.Debug.WriteLine(ex.Message);
}
}
}
}
}

0 comments on commit d1035ac

Please sign in to comment.