Upgarde to latest packages, should fix tareting android s

jamesmontemagno · Feb 22, 2022 · 2f917ac · 2f917ac
1 parent 905874d
commit 2f917ac
Show file tree

Hide file tree

Showing 5 changed files with 2,587 additions and 1,993 deletions.
diff --git a/src/StoreReview.Plugin/StoreReview.Plugin.csproj b/src/StoreReview.Plugin/StoreReview.Plugin.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="MSBuild.Sdk.Extras/2.1.2">
 
   <PropertyGroup>
-    <TargetFrameworks>netstandard1.0;netstandard2.0;MonoAndroid10.0;Xamarin.Mac20;Xamarin.iOS10;uap10.0.16299;Xamarin.TVOS10;</TargetFrameworks>
+    <TargetFrameworks>netstandard1.0;netstandard2.0;MonoAndroid10.0;Xamarin.Mac20;Xamarin.iOS10;uap10.0.19041;Xamarin.TVOS10;</TargetFrameworks>
     <AssemblyName>Plugin.StoreReview</AssemblyName>
     <RootNamespace>Plugin.StoreReview</RootNamespace>
     <AssemblyVersion>1.0.0.0</AssemblyVersion>
@@ -70,8 +70,8 @@
 
   <ItemGroup Condition=" $(TargetFramework.StartsWith('MonoAndroid')) ">
     <Compile Include="**\*.android.cs" />
-		<PackageReference Include="PlayCore" Version="1.10.0" />
-		<PackageReference Include="Xamarin.Essentials" Version="1.6.1" />
+		<PackageReference Include="PlayCore" Version="1.10.2-rc2" />
+		<PackageReference Include="Xamarin.Essentials" Version="1.7.1" />
   </ItemGroup>
 
   <ItemGroup Condition=" $(TargetFramework.StartsWith('Xamarin.iOS')) ">

diff --git a/src/StoreReview.Plugin/StoreReviewImplementation.apple.cs b/src/StoreReview.Plugin/StoreReviewImplementation.apple.cs
@@ -86,7 +86,7 @@ public Task RequestReview(bool testMode)
 					if (windowScene != null)
 					{
 						SKStoreReviewController.RequestReview(windowScene);
-						return;
+						return Task.CompletedTask;
 					}
 				}
                 SKStoreReviewController.RequestReview();

diff --git a/src/StoreReviewTest/StoreReviewTest.Android/Properties/AndroidManifest.xml b/src/StoreReviewTest/StoreReviewTest.Android/Properties/AndroidManifest.xml
@@ -1,6 +1,6 @@
-<?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="1" android:versionName="1.0" package="com.companyname.storereviewtest">
-    <uses-sdk android:minSdkVersion="21" android:targetSdkVersion="28" />
-    <application android:label="StoreReviewTest.Android" android:theme="@style/MainTheme"></application>
-    <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
-</manifest>
+<?xml version="1.0" encoding="utf-8"?>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="1" android:versionName="1.0" package="com.companyname.storereviewtest" android:installLocation="auto">
+	<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="31" />
+	<application android:label="StoreReviewTest.Android" android:theme="@style/MainTheme"></application>
+	<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
+</manifest>