Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Radar Chart #114

Closed
jamesleesaunders opened this issue Jun 30, 2018 · 5 comments
Closed

New Radar Chart #114

jamesleesaunders opened this issue Jun 30, 2018 · 5 comments
Labels
fiverr Job posted on www.fiverr.com

Comments

@jamesleesaunders
Copy link
Owner

jamesleesaunders commented Jun 30, 2018

This request is to add a new Radar Chart (and component) to d3-ez.

The Radar Chart should be added across 2 new files:
/src/chart/radarChart.js
/src/component/radar.js

Use pre-existing components for the circular axis and labels:
/src/component/circularAxis.js
/src/component/circularSectorLabels.js

As a base you could start with:
/src/chart/polarAreaChart.js

An new example file should also be created:
/examples/RadarChartExample.html

See the following example(s):
https://en.wikipedia.org/wiki/Radar_chart
https://datavizcatalogue.com/methods/radar_chart.html
http://datavizproject.com/data-type/radical-line-graph/

@jamesleesaunders jamesleesaunders added the fiverr Job posted on www.fiverr.com label Jul 1, 2018
@DipParmar
Copy link
Contributor

d3-ez.txt

radarChart.txt
RadarChartExample.txt

Please find the these files with changes..

@jamesleesaunders
Copy link
Owner Author

Thanks Dip,

I have taken your files and imported them into the repo. Looking good and so nearly there!

I have also managed to finish off the color scale and legend so it now works well.
screen shot 2018-07-09 at 22 53 44

You can take a look at the change I made here:
https://github.com/jamesleesaunders/d3-ez/blob/RadarChart/src/chart/radarChart.js
and
https://github.com/jamesleesaunders/d3-ez/blob/RadarChart/examples/RadarChartExample.html

There is still a little bit of work to do on the tool top section which I have commented out for now. I will try and get that going tomorrow.

The main change I made were:

  • Fixed calculation of 'angleSlice' size.
  • Swapped color scale to use group (series) names rather than category names.
  • Swapping var's for let's (To make ES6 compliant).
  • Few other odds and ends.

It is looking much better now.

Thanks for all your help Dip! You are a super star!

Once we have it fully working the next step is to move the radar generation code into its own mini component which is then called by the parent chartRadar.js.

@DipParmar
Copy link
Contributor

DipParmar commented Jul 10, 2018 via email

@jamesleesaunders
Copy link
Owner Author

Hi @DipParmar
I have polished off the Radar chart and moved some of the code to a new component.
I have just published v3.3.12 which includes your contributions.
Thanks again. Now you know more of the inside of d3-ez if you do think of any additions to the docs & README.md please feel free to raise a pull request for any changes.
All the best,
Jim

@DipParmar
Copy link
Contributor

DipParmar commented Jul 11, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fiverr Job posted on www.fiverr.com
Projects
None yet
Development

No branches or pull requests

2 participants